search

expo / config-plugins

Out-of-tree Expo config plugins for packages that haven't adopted the config plugin system yet.
428 stars 91 forks source link

@config-plugins/react-native-ble-plx 3.0.0 (SDK 46) needs @expo/config-plugins peer-dep #124

Open nmschulte-aviture opened 1 year ago

nmschulte-aviture commented 1 year ago

Summary

@config-plugins/react-native-ble-plx v3.0.0, bringing Expo SDK v46 support, ...

  1. needs @expo/config-plugins peerDependency specification
  2. needs release notes
  3. is now out of sync w/re: versioning of react-native-ble-plx package

Otherwise this fails to work on MacOS / Node.js v16:

Build failed
Cannot find module '@expo/config-plugins'
Require stack:
- /Users/expo/workingdir/build/node_modules/@config-plugins/react-native-ble-plx/build/withBLE.js
- /Users/expo/workingdir/build/node_modules/@config-plugins/react-native-ble-plx/app.plugin.js
- /usr/local/eas-build-worker/node_modules/@expo/build-tools/node_modules/@expo/config-plugins/build/utils/plugin-resolver.js
- /usr/local/eas-build-worker/node_modules/@expo/build-tools/node_modules/@expo/config-plugins/build/plugins/withStaticPlugin.js
- /usr/local/eas-build-worker/node_modules/@expo/build-tools/node_modules/@expo/config-plugins/build/plugins/withPlugins.js
- /usr/local/eas-build-worker/node_modules/@expo/build-tools/node_modules/@expo/config-plugins/build/index.js
- /usr/local/eas-build-worker/node_modules/@expo/build-tools/dist/android/expoUpdates.js
- /usr/local/eas-build-worker/node_modules/@expo/build-tools/dist/utils/expoUpdates.js
- /usr/local/eas-build-worker/node_modules/@expo/build-tools/dist/builders/android.js
- /usr/local/eas-build-worker/node_modules/@expo/build-tools/dist/builders/index.js
- /usr/local/eas-build-worker/node_modules/@expo/build-tools/dist/index.js
- /usr/local/eas-build-worker/src/services/worker/dist/ios/build.js
- /usr/local/eas-build-worker/src/services/worker/dist/build.js
- /usr/local/eas-build-worker/src/services/worker/dist/service.js
- /usr/local/eas-build-worker/src/services/worker/dist/ws.js
- /usr/local/eas-build-worker/src/services/worker/dist/main.js

Config Plugin

@config-plugins/react-native-ble-plx

What platform(s) does this occur on?

iOS

SDK Version

46

Reproducible demo

Simply try to use @config-plugins/react-native-ble-plx as specified w/ a blank Expo project (no top-level @expo/config-plugins deps).

Svarto commented 1 year ago

Did anyone find a solution here? I've the same issue got react-native-branch

nmschulte-aviture commented 1 year ago

You can specify a [peer-]dep in your own package, which works around this issue for now, e.g.:

--- a/package.json
+++ b/package.json
   },
+  "peerDependencies": {
+    "@expo/config-plugins": "^5.0.1"
+  },
   "overrides": {