expo / config-plugins

Out-of-tree Expo config plugins for packages that haven't adopted the config plugin system yet.
428 stars 91 forks source link

[react-native-branch] SDK 47 only builds for ios 13+ but podspec still has 12 #127

Closed Aryk closed 10 months ago

Aryk commented 1 year ago

Summary

I believe we need to bump the ios version to 13 from 12.

Screen Shot 2022-11-08 at 6 31 56 PM

Config Plugin

@config-plugins/react-native-branch

What platform(s) does this occur on?

iOS

SDK Version

47

Reproducible demo

Try building with eas

  "react-native-branch": "^5.6.2",
    "@config-plugins/react-native-branch": "^3.0.0",

Possible Solution

diff --git a/node_modules/@config-plugins/react-native-branch/ios/ExpoAdapterBranch.podspec b/node_modules/@config-plugins/react-native-branch/ios/ExpoAdapterBranch.podspec
index 83ef935..a0a6f42 100644
--- a/node_modules/@config-plugins/react-native-branch/ios/ExpoAdapterBranch.podspec
+++ b/node_modules/@config-plugins/react-native-branch/ios/ExpoAdapterBranch.podspec
@@ -10,7 +10,8 @@ Pod::Spec.new do |s|
   s.license        = package['license']
   s.author         = package['author']
   s.homepage       = package['homepage']
-  s.platform       = :ios, '12.0'
+  # Expo SDK 47 requires ios 13 and above.
+  s.platform       = :ios, '13.0'
   s.swift_version  = '5.4'
   s.source         = { git: 'https://github.com/expo/config-plugins.git' }
   s.static_framework = true
Calvin-Octoco commented 1 year ago

Any updates on this issue?

felixliu226 commented 1 year ago

same issue happened... I refered to this answer I changed Pods > ExpoModulesCore > Build Settings > iOS Deplyment Target to iOS 12.0, and it works on my local.

But when using eas build, it failed with the same error... Hope someone could help to fix this.

jeffreybrowning commented 1 year ago

Still happening

Calvin-Octoco commented 1 year ago

@jeffreybrowning did you upgrade to the latest plugin version? This fixed the issue for me.

jeffreybrowning commented 1 year ago

Will try so today -- I ended up removing branch from recent deploys rather than fight this.

ebo7 commented 1 year ago

If anyone having trouble, turns out expo upgrade doesn't update this library but the plugin version 4 seems working for expo 47!

Aryk commented 10 months ago

Confirmed that it's upgrade to 13.0 on the latest plugin version, closing the ticket.