expo / config-plugins

Out-of-tree Expo config plugins for packages that haven't adopted the config plugin system yet.
427 stars 91 forks source link

ExpoSDK49 peer dependency issue #178

Closed chulanovskyi-bs closed 11 months ago

chulanovskyi-bs commented 12 months ago

Summary

Hello! Recently, Expo have released an 49 version of SDK and the following plugin starts to fail on the installation step:

image

Running "npm install" in /home/expo/workingdir/build directory

[stderr] 
npm ERR!
[stderr] 
code ERESOLVE
[stderr] 
npm
[stderr] 
ERR! ERESOLVE could not resolve
[stderr] 
npm ERR!
[stderr] 
npm ERR! While resolving: @config-plugins/react-native-branch@5.0.0
[stderr] 
npm
[stderr] 
ERR! Found: expo@49.0.0
[stderr] 
npm ERR! node_modules/expo
[stderr] 
npm ERR!   expo@"49.0.0" from the root project
[stderr] 
npm ERR!   peer expo@"*" from expo-application@5.3.0
[stderr] 
npm ERR!   node_modules/expo-application
[stderr] 
npm ERR!     expo-application@"5.3.0" from the root project
[stderr] 
npm ERR!     expo-application@"~5.3.0" from expo@49.0.0
[stderr] 
npm ERR!
[stderr] 
2 more (expo-notifications, sentry-expo)
[stderr] 
npm ERR!   19 more (expo-constants, expo-dev-client, expo-dev-launcher, ...)
[stderr] 
npm ERR! 
[stderr] 
npm ERR! Could not resolve dependency:
[stderr] 
npm ERR! peer expo@"^48" from @config-plugins/react-native-branch@5.0.0
[stderr] 
npm ERR! node_modules/@config-plugins/react-native-branch
[stderr] 
npm ERR!   @config-plugins/react-native-branch@"5.0.0" from the root project
[stderr] 
npm ERR! 
[stderr] 
npm ERR! Conflicting peer dependency: expo@48.0.19
[stderr] 
npm ERR! node_modules/expo
[stderr] 
npm ERR!   peer expo@"^48" from @config-plugins/react-native-branch@5.0.0
[stderr] 
npm ERR!   node_modules/@config-plugins/react-native-branch
[stderr] 
npm ERR!     @config-plugins/react-native-branch@"5.0.0" from the root project

I'll be extremely appreciated if someone please upgrade the dependency. Thank you in advance

Config Plugin

@config-plugins/react-native-branch

What platform(s) does this occur on?

Android, iOS

SDK Version

49

Reproducible demo

Push the expo-based project which have the following in its package.json:

...
"@config-plugins/react-native-branch": "5.0.0",
"expo": "49.0.0",
...
anatoleblanc commented 11 months ago

Would be a life saver yep

stefan-schweiger commented 11 months ago

@EvanBacon when will this fix be released to npm?

EDIT: Just saw that there apparently are already new versions, but just not listed under releases here