expo / config-plugins

Out-of-tree Expo config plugins for packages that haven't adopted the config plugin system yet.
427 stars 91 forks source link

feat: intercom-react-native #208

Closed enagorny closed 4 months ago

enagorny commented 7 months ago

Why

Expo support for intercom existing plugin isn't actively maintained and has some crucial issues

The original author of the config plugin suggested previously to have it here. However this code isn't based on the https://github.com/cmaycumber/config-plugin-react-native-intercom . It is based on the gist by wcastand

Limitations

How

Created new config plugin

Test Plan

Tested it locally

yonitou commented 7 months ago

Hi @enagorny I'm also waiting for a rebirth of the intercom <-> expo plugin so thanks for starting it :) I think many of us are using push notifications with Intercom. Do you think that using the code from https://github.com/cmaycumber/config-plugin-react-native-intercom for the notifications could be an idea ?

enagorny commented 7 months ago

@yonitou I think it is a good time to review the approach of push notification setup. Since the https://github.com/cmaycumber/config-plugin-react-native-intercom was introduced I believe expo conflig plugins became more powerful and intercom setup instructions might be changed. This is still in my TODO list

Joshandrews43 commented 6 months ago

commenting to show support for this project

yonitou commented 6 months ago

+1 When does this PR will be reviewed ? It's really important for the Intercom community

GabrielDierks commented 5 months ago

+1

GabrielDierks commented 5 months ago

@brentvatne Can you guys please have a look? <3 Intercom is crucial for a lot of expo apps and unfortunately they introduced a lot of important fixes in their latest versions which cannot be accessed by the current unmaintained config plugin. 🙏

enagorny commented 5 months ago

I think the expo team might want to postpone this until SDK 50 is released. react-native-intercom 6.* requires compileSdkVersion: 34 which will be the default in SDK 50.

Having compileSdkVersion 34 in expo SDK 49 might lead to issues and may require patching some expo packages(we have already done one for the expo-image-loader).

brentvatne commented 5 months ago

thank you for this PR! what do you think about opening this directly to https://github.com/intercom/intercom-react-native/pulls? ideally, the config plugin for a library sits alongside it directly so it can stay in sync with releases.

erwanlpfr commented 5 months ago

Hello !

I opened a PR in intercom repo. Let me know if you want to add anything.

https://github.com/intercom/intercom-react-native/pull/155

yonitou commented 5 months ago

Hi @brentvatne, Looks like Intercom is not very "responsive" atm.

They don't have an issue panel on their Github repository so I don't even know if this is really an open source repository (all the pull requests have been created and merged by Intercom developers).

I don't have a lot of hope about adding and maintaining the plugin from Intercom repository. Do you think we can add it here ?

Thanks,

yonitou commented 4 months ago

UPDATE : Intercom just answered and are looking into the PR !

@enagorny : did you have time to check about push notifications support for this plugin ? I suppose that if Intercom merges this PR, it's better if it's almost complete so we are not bothering them again in some weeks

Seamus1989 commented 4 months ago

commenting for support!

yonitou commented 4 months ago

Intercom just merged the PR :) I think this thread can be closed because it's not concerning Expo Team anymore.