expo / config-plugins

Out-of-tree Expo config plugins for packages that haven't adopted the config plugin system yet.
465 stars 99 forks source link

refactor!: upgrade to Expo SDK 50 #211

Closed byCedric closed 9 months ago

byCedric commented 9 months ago

Why

New year, new SDK.

How

Test Plan

TBD

byCedric commented 9 months ago

Lmao, thanks yarn... image

fobos531 commented 9 months ago

@byCedric

react-native-branch also experiences a compilation error on SDK 50 due to AGP 8, for that I've submitted a minor PR to fix it: https://github.com/expo/config-plugins/pull/216

fobos531 commented 9 months ago

@byCedric

About react-native-branch... are you certain that Android needs additional work? I just checked their setup docs for Android and it looks to be exactly what is already present in the lifecycle listeners implemented here:

https://github.com/expo/config-plugins/blob/main/packages/react-native-branch/android/src/main/java/expo/modules/adapters/branch/BranchReactActivityLifecycleListener.kt

https://github.com/expo/config-plugins/blob/main/packages/react-native-branch/android/src/main/java/expo/modules/adapters/branch/BranchApplicationLifecycleListener.kt

So I'm not sure what else would there need to be adjusted (besides #216)

fobos531 commented 9 months ago

Some more info about react-native-webrtc compatibility and Hermes failure can be seen by tracing the info in this comment: https://github.com/react-native-webrtc/react-native-webrtc/issues/1503#issuecomment-1918947695

doug-shontz commented 9 months ago

Any progress on this?

I had the bad luck of trying to convince my new team to use Expo and it turns out the day I tried to have people look at setting up a new project was the day AFTER Expo 50 came out (we were waiting on the Expo Router v3 changes). We use Google Cast and Detox on our raw RN apps and so their testing started failing almost immediately just for NPM not wanting to install the right packaging (we are not allowed to use legacy deps).

We backpedalled to Expo 49 and was able to get things working, but, since our main interest was in the changes to the Expo router that were released in Expo 50, that made a huge dent in trying to sell Expo's stability to our management.

No shade thrown for this...I understand the complexity. Just hoping this gets solved soon enough for us to not miss our start window on our new projects!

macsinte commented 9 months ago

react-native-branch does not currently work on iOS anymore for SDK 50, but it does seem to work on Android.

Does this cover that as well?

See #215.

akkilaa commented 9 months ago

@macsint My android's build is failing image

EvanBacon commented 9 months ago

I'll be taking over this upgrade today

macsinte commented 9 months ago

@macsint My android's build is failing image

@akkilaa yes, you can refer to the issue that I initially referred to in my post #215 in order to do a patch until a PR is merged with a fix. Which by the looks of it it's being worked on.

I already built this with Expo SDK 50 for Android with that patch and it works.

EvanBacon commented 9 months ago

The webrtc issue is related to their use of event-target-shim@6 colliding with React Native's usage of event-target-shim@5.

EvanBacon commented 9 months ago

https://github.com/expo/config-plugins/pull/220