search

expo / config-plugins

Out-of-tree Expo config plugins for packages that haven't adopted the config plugin system yet.
470 stars 101 forks source link

fix: AGP 8 compatibility for react-native-branch #216

Closed fobos531 closed 9 months ago

fobos531 commented 10 months ago

Why

[RUN_GRADLEW] Execution failed for task ':config-plugins-react-native-branch:compileDebugKotlin'.
[RUN_GRADLEW] > 'compileDebugJavaWithJavac' task (current target is 17) and 'compileDebugKotlin' task (current target is 11) jvm target compatibility should be set to the same Java version.
[RUN_GRADLEW]   Consider using JVM toolchain: https://kotl.in/gradle/jvm/toolchain

How

https://github.com/expo/fyi/blob/main/expo-modules-gradle8-migration.md#error-task-current-target-is-17-and-compilereleasekotlin-task-current-target-is-11-jvm-target-compatibility-should-be-set-to-the-same-java-version

Test Plan

The app properly compiles on SDK 50

manuelmhtr commented 9 months ago

@fobos531 It worked for me. Thank you! I hope it gets merged soon.

EvanBacon commented 9 months ago

Fixed in https://github.com/expo/config-plugins/pull/220