expo / config-plugins

Out-of-tree Expo config plugins for packages that haven't adopted the config plugin system yet.
427 stars 91 forks source link

fix: update callkeep to support newer android targetSdks #223

Open santhoshvai opened 4 months ago

santhoshvai commented 4 months ago

Why

According to the callkeep library to target android versions > 11, android:foregroundServiceType="camera|microphone" must be used

How

Test Plan

EvanBacon commented 4 months ago

The minimum Android version in Expo is 6 (?) https://docs.expo.dev/versions/latest/#support-for-android-and-ios-versions

santhoshvai commented 4 months ago

@EvanBacon this change does not impact the minimum versions. Infact, the foregroundServiceType started only from android 10. It is just that when a newer targetSdk is used, which is commonly 33 now (android 13) the foregroundServiceType is mandatory.