search

expo / config-plugins

Out-of-tree Expo config plugins for packages that haven't adopted the config plugin system yet.
427 stars 91 forks source link

fix: event-target-shim/package.json Package subpath './index' is not defined in `react-native-webrtc` config plugin #235

Open mrakesh0608 opened 1 month ago

mrakesh0608 commented 1 month ago

Why

Fixes #1569

How

react-native-webrtc already forcing to use the correct event-target-shim module #1515.

Test

When event-target-shim is requested by react-native-webrtc, Metro by default resolves event-target-shim relative to react-native-webrtc.

When both variables isEventTargetShimPkg and isWebrtc are true, event-target-shim is resolved relative to react-native-webrtc, as shown in the video.

So, there is no need to explicitly resolve event-target-shim for react-native-webrtc.

https://github.com/expo/config-plugins/assets/101246871/6ad38742-4145-4b07-9047-b3fb8b7652c1

Screenshot 2024-05-16 at 7 33 41 PM

mrakesh0608 commented 3 weeks ago

Hi @EvanBacon, I have tested Expo SDK 50 with react-native-webrtc@118.0.4 and @config-plugins/react-native-webrtc@7.0.0, and it is working fine. I think it would be better if we update the compatibility table.