Branch plugin doesn't work with "test" API keys - Githubissues

expo / config-plugins

Out-of-tree Expo config plugins for packages that haven't adopted the config plugin system yet.

467 stars 99 forks source link

Branch plugin doesn't work with "test" API keys #241

Open jvgeee opened 4 months ago

jvgeee commented 4 months ago

Library

https://github.com/expo/config-plugins/tree/main/packages/react-native-branch

Summary

When using Branch with the expo config-plugin, the plugin takes in an apiKey parameter. This adds an entry to the info.plist for:

<key>branch_key</key>
    <dict>
      <key>live</key>
      <string>key_xxxxx</string>
    </dict>

If you put a test key into your app.json config, then the SDK won't properly connect to the test environment of Branch; it still has a live key, and there's a mismatch, so none of your links can be properly processed by the SDK.

My requests:

Add a parameter for a testApiKey within the app.json config
Add a flag to enable debugging logs for Branch if possible

Any existing examples?

No response

jvgeee commented 4 months ago

Was gonna make a PR for this but realised there already is one here that's been waiting for a review for months:

https://github.com/expo/config-plugins/pull/229

@EvanBacon / @maintainers, can this be reviewed and merged in please?

belle-chang commented 3 months ago

+1, please review https://github.com/expo/config-plugins/pull/229

j3lev commented 1 month ago

Any chance we could get please get eyes on this PR?

madhav-nasit commented 3 weeks ago

+1