expo / config-plugins

Out-of-tree Expo config plugins for packages that haven't adopted the config plugin system yet.

445 stars 95 forks source link

Add Adjust SDK config plugin #37

Closed Kerumen closed 2 years ago

Kerumen commented 2 years ago

Why

Add config plugin for Adjust SDK
Resolve https://github.com/expo/config-plugins/issues/35

Test Plan

Run expo prebuild
On iOS, ensure the 5 libraries are linked properly with the optional status:

Screenshot 2022-01-12 at 10 07 11

On Android, ensure the permission is here and the dependencies are added in the app build.gradle file:

Screenshot 2022-01-12 at 10 10 11

Kerumen commented 2 years ago

@EvanBacon I updated the PR and the description. To be noted, I can't add the config-plugin in the example app from npm because it's not yet published so i added it with a file: reference.

Kerumen commented 2 years ago

@EvanBacon I've added the option. I named it targetAndroid12 because the Adjust docs says that the Google Advertising Id should be used since 2014. Hence, this could be confusing to name it enableGoogleAdId. Maybe enableGoogleAdIdForAndroid12 but that's a bit long. Tell me if you have a better name in mind!

Screenshot 2022-01-14 at 17 16 48

EvanBacon commented 2 years ago

Congrats @config-plugins/react-native-adjust@0.0.1 is now published! Thanks for the hard work 🎉