search

expo / config-plugins

Out-of-tree Expo config plugins for packages that haven't adopted the config plugin system yet.
433 stars 92 forks source link

feat(react-native-webrtc): add config mod for Android minSdkVersion 24 #57

Closed thorbenprimke closed 2 years ago

thorbenprimke commented 2 years ago

Why

react-native-webrtc requires that the Android minSdkVersion is set to 24. Related issue on this here and also mentioned on Daily's RN SDK that has react-native-webrtc as a dependency.

Adds withBuildScriptExtMinimumVersion same as the ffmpeg-kit-react-native config plugin. Maybe withBuildScriptExtMinimumVersion could be exported in config-plugins package so that it could be used directly.

How

Added withBuildScriptExtMinimumVersion plugin and used it to set the minSdkVersion to 24

Test Plan

1) Created a patch-package with the code changes. 2) Verified with expo prebuild -p android that the generated source now has minSdkVersion set to 24. By default / without the config plugin change it would be 21.

thorbenprimke commented 2 years ago

Could you also add a note to the README which informs users about the minimum version change, it's one of the bigger changes a plugin could make.

Thanks for the review @EvanBacon. I updated the PR and added the note to the README.