expo / config-plugins

Out-of-tree Expo config plugins for packages that haven't adopted the config plugin system yet.

433 stars 92 forks source link

feat!: add SDK 45 support #79

Closed EvanBacon closed 2 years ago

EvanBacon commented 2 years ago

How

Split up the tests in apps/ to make it easier to test individual apps.
Upgrade all packages to SDK 45

Test Plan

Build all apps in apps/ on iOS and Android

karlhorky commented 2 years ago

Is @config-plugins/detox not required to be in app.json under plugins anymore? (the docs still mention that it should be configured there)

I noticed it was removed in this PR here: https://github.com/expo/config-plugins/pull/79/files#diff-7487a2b685a1de6c596646931ae52c8ba5df6e57f33b7b1136a01e2b969f2b91L68

Oh, maybe it's because of lack of React Native 0.68 support in Detox?

Although it seems there is a workaround for now: https://github.com/wix/Detox/issues/3344#issuecomment-1111197955