expo / custom-expo-updates-server

238 stars 67 forks source link

fix: add metadata and extra fields to manifest to satisfy protocol #19

Closed wschurman closed 1 year ago

wschurman commented 1 year ago

This fixes (1) from https://github.com/expo/custom-expo-updates-server/issues/12#issuecomment-1334121928.

Investigation into this revealed that the only place that https://github.com/expo/expo/blob/main/packages/expo-manifests/android/src/main/java/expo/modules/manifests/core/Manifest.kt#L229 is used (in this library) is https://github.com/expo/expo/blob/main/packages/expo-updates/android/src/main/java/expo/modules/updates/selectionpolicy/SelectionPolicies.kt#L22, so it would just return true (erroneously).