search

expo / detox-expo-helpers

44 stars 34 forks source link

reloadApp not working for detox version above 7.2.0 #8

Closed tatane616 closed 6 years ago

tatane616 commented 6 years ago

When running command detox test, reloadApp() not working for detox version above 7.2.0. Less than 7.2.0, It works normally.

"dependencies": {
    "expo": "^29.0.0",
    "react": "16.2.0",
    "react-native": "https://github.com/expo/react-native/archive/sdk-29.0.0.tar.gz"
  },
  "devDependencies": {
    "detox": "7.3.0",
    "detox-expo-helpers": "^0.2.0",
    "mocha": "^4.0.1"
  },

I want to enable artifacts such as device logs, device screenshots and screen recordings, but it does not correspond to detox 7.2.0 or lower. https://github.com/wix/Detox/blob/master/docs/APIRef.Artifacts.md Is there any solution?

watanabeyu commented 6 years ago

This problem is caused by await this.deviceDriver.waitUntilReady() from v8.0.0. (https://github.com/wix/detox/blob/master/detox/src/devices/Device.js#L89)

So detox-expo-helpers is not wrong.

If you use wix/detox above 7.2.0, detach expo.

haikyuu commented 5 years ago

Any workarounds for this? Any way we can avoid detaching?