search

expo / detox-expo-helpers

44 stars 34 forks source link

fix expo/detox issue that hangs at launch #9

Closed quinlanj closed 5 years ago

quinlanj commented 5 years ago

fixes https://github.com/wix/Detox/issues/917

In order to fix the hanging issue at launch app, this pr does the following:

  1. pass in the blacklist args at device initialization
  2. pass in a custom ios framework that we use at runtime with expotox test
  3. write docs to tell ppl abt these changes
quinlanj commented 5 years ago

These fixes will only work in the upcoming version of detox (9.0.6?)

brentvatne commented 5 years ago

lgtm! do you think there are any cases where people would need to add their own urls to the blacklist or is this list definitive for the current version of expo client?

brentvatne commented 5 years ago

These fixes will only work in the upcoming version of detox (9.0.6?)

can we somehow verify at install time that the version of detox is compatible?

brentvatne commented 5 years ago

also we should update the example project if necessary

quinlanj commented 5 years ago

These fixes will only work in the upcoming version of detox (9.0.6?)

can we somehow verify at install time that the version of detox is compatible?

hmm good idea. i can check the detox version on the project's node_modules to determine this

quinlanj commented 5 years ago

also we should update the example project if necessary

will do!

quinlanj commented 5 years ago

lgtm! do you think there are any cases where people would need to add their own urls to the blacklist or is this list definitive for the current version of expo client?

so for an expo-fied app, this is the minimum set of urls that will need to be blacklisted, but in general, any endpoint that an app calls a lot will hang launchApp. i'll add a param in our helpers so ppl can pass additional urls if they want