search

expo / dev-plugins

Out-of-tree Expo devtools plugins for packages that haven't adopted the Expo devtools plugin system yet.
MIT License
154 stars 24 forks source link

[async-storage]: Fix inline editing cursor jump #36

Closed Thomas-Gallant closed 6 months ago

Thomas-Gallant commented 7 months ago

When attempting to update a value through async storage devtools UI, the cursor is moved to the beginning of the text input.

This change disables re-rendering of the Value column cells as the user is typing. This issue no longer appears, and functionality of saving changes, adding and removing key-value pairs does not appear to be affected by this change.

Fixes #23

Kudo commented 7 months ago

@jthoward64 could you help to review the change when you get a chance?

jthoward64 commented 6 months ago

If this isn't going to be merged I'm willing to pull out the async storage plugin and maintain it myself

Kudo commented 6 months ago

thanks @Thomas-Gallant and @jthoward64 for helping this change. i'm merging the pr and publish updates soon.