expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
676 stars 74 forks source link

[ENG-11658][eas-cli] Add --no-channel flag for update and rollback to embedded #2339

Closed quinlanj closed 1 month ago

quinlanj commented 1 month ago

Why

When users create an update, we make sure that the branch they publish to is linked to a channel of the same name. However, this behaviour is not always desirable. For example, in the development usecase where someone is trying to load their update in the dev-client, a channel is not necesary. Users will either navigate to the update they want in the dev client menu or via a preview QR code.

When we've interviewed users who use the dev client/qr code flow, they are always running eas delete:channel after the eas update command.

How

This PR adds a flag, --no-channel for the development usecase. This prevents a channel from being automatically created.

Test Plan

linear[bot] commented 1 month ago

ENG-11658 Add a way to not create channel on update

github-actions[bot] commented 1 month ago

Size Change: -725 B (0%)

Total Size: 51.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.4 MB -725 B (0%)

compressed-size-action

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.67%. Comparing base (44cd3b2) to head (7a669bc). Report is 4 commits behind head on main.

Files Patch % Lines
...s-cli/src/commands/update/roll-back-to-embedded.ts 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2339 +/- ## ========================================== + Coverage 53.66% 53.67% +0.02% ========================================== Files 525 525 Lines 19264 19272 +8 Branches 4066 4070 +4 ========================================== + Hits 10336 10343 +7 - Misses 8203 8204 +1 Partials 725 725 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

quinlanj commented 1 month ago

/changelog-entry new-feature Add --no-channel flag for update and rollback to embedded

github-actions[bot] commented 1 month ago

✅ Thank you for adding the changelog entry!

quinlanj commented 1 month ago

closing in favour of https://github.com/expo/eas-cli/pull/2346 , appreciate the code suggestions tho, @szdziedzic !