Closed quinlanj closed 1 month ago
Size Change: -725 B (0%)
Total Size: 51.4 MB
Filename | Size | Change |
---|---|---|
./packages/eas-cli/dist/eas-linux-x64.tar.gz |
51.4 MB | -725 B (0%) |
Attention: Patch coverage is 85.71429%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 53.67%. Comparing base (
44cd3b2
) to head (7a669bc
). Report is 4 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...s-cli/src/commands/update/roll-back-to-embedded.ts | 75.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/changelog-entry new-feature Add --no-channel flag for update and rollback to embedded
✅ Thank you for adding the changelog entry!
closing in favour of https://github.com/expo/eas-cli/pull/2346 , appreciate the code suggestions tho, @szdziedzic !
Why
When users create an update, we make sure that the branch they publish to is linked to a channel of the same name. However, this behaviour is not always desirable. For example, in the development usecase where someone is trying to load their update in the dev-client, a channel is not necesary. Users will either navigate to the update they want in the dev client menu or via a preview QR code.
When we've interviewed users who use the dev client/qr code flow, they are always running
eas delete:channel
after theeas update
command.How
This PR adds a flag,
--no-channel
for the development usecase. This prevents a channel from being automatically created.Test Plan