Closed szdziedzic closed 1 month ago
/changelog-entry chore Don't prompt users to set push notifications by default if they don't have the expo-notifications
installed
Size Change: -392 B (0%)
Total Size: 51.4 MB
Filename | Size | Change |
---|---|---|
./packages/eas-cli/dist/eas-linux-x64.tar.gz |
51.4 MB | -392 B (0%) |
Attention: Patch coverage is 25.00000%
with 6 lines
in your changes are missing coverage. Please review.
Project coverage is 53.67%. Comparing base (
bc2f6e6
) to head (ed4558a
).:exclamation: Current head ed4558a differs from pull request most recent head 90c5172. Consider uploading reports for the commit 90c5172 to get more accurate results
Files | Patch % | Lines |
---|---|---|
...-cli/src/credentials/ios/IosCredentialsProvider.ts | 20.00% | 3 Missing and 1 partial :warning: |
packages/eas-cli/src/project/projectUtils.ts | 33.34% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
very reasonable! i requested review from @douglowder and @christopherwalter since they work on notifications
awesome, thanks!
btw, we should check the onesignal docs to ensure that this doesn't cause any issues with their instructions
✅ Thank you for adding the changelog entry!
Why
https://linear.app/expo/issue/ENG-12122/dont-prompt-people-to-set-push-notifications-by-default-if-they-dont
It was noticed that these prompts not always make sense and may be annoying
How
don't prompt users to set push notifications by default if they don't have the
expo-notifications
installedTest Plan
test manually
with
promptToConfigurePushNotifications
not set andexpo-notifications
not installed:with
promptToConfigurePushNotifications
not set andexpo-notifications
installed: