Closed quinlanj closed 1 month ago
/changelog-entry breaking-change Stop creating a channel on eas update
and eas update:roll-back-to-embedded
unless the --channel
flag is specified
✅ Thank you for adding the changelog entry!
Size Change: +2.96 kB (0%)
Total Size: 51.4 MB
Filename | Size | Change |
---|---|---|
./packages/eas-cli/dist/eas-linux-x64.tar.gz |
51.4 MB | +2.96 kB (0%) |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 53.68%. Comparing base (
d9092e1
) to head (5cf760c
). Report is 7 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Related consequence of this: https://github.com/expo/expo/issues/29205. I think this is still the right call, but we'll need to audit the docs for local builds to ensure channels are manually created since they're no longer generated here.
Why
An alternative solution to https://github.com/expo/eas-cli/pull/2339 , after talking to @jonsamp and @wschurman
When users create an update, we make sure that the branch they publish to is linked to a channel of the same name. However, this behaviour is not always desirable. For example, in the development usecase where someone is trying to load their update in the dev-client, a channel is not necesary. Users will either navigate to the update they want in the dev client menu or via a preview QR code.
How
--channel
flag is passedTest Plan
eas update --channel bar
creates channelbar
, links it to branchbar
, then publishes an update to the brancheas update:roll-back-to-embedded --channel bar
creates channelbar
, links it to branchbar
, then publishes an update to the brancheas update --branch bar
andeas update --auto
no longer create a channeleas update:roll-back-to-embedded --branch bar
andeas update:roll-back-to-embedded --auto
no longer create a channel