expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
676 stars 74 forks source link

[eas-cli] Show the -s, --sso option in the login command help. #2353

Closed lzkb closed 1 month ago

lzkb commented 1 month ago

Why

As noted by @jonsamp, the login info message was not clear. It was changed to show use of 'login --help' to see more login options. On checking, the sso login option was missing/hidden in the help and README.

Related PR: https://github.com/expo/eas-cli/pull/2352

How

Added back the login help option.

Test Plan

Checked login help locally before making any changes:

`eas-cli % ./bin/run login --help log in with your Expo account

USAGE $ eas login [-s]

FLAGS -s, --sso Login with SSO

DESCRIPTION log in with your Expo account

ALIASES $ eas login `

Login help after adding back the sso help:

`eas-cli % ./bin/run login --help
log in with your Expo account

USAGE $ eas login [-s]

FLAGS -s, --sso Login with SSO

DESCRIPTION log in with your Expo account

ALIASES $ eas login

`

lzkb commented 1 month ago

/changelog-entry bug-fix Show the -s, --sso option in the login command help.

github-actions[bot] commented 1 month ago

Size Change: +200 B (0%)

Total Size: 51.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.4 MB +200 B (0%)

compressed-size-action

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.68%. Comparing base (6ac1e54) to head (6fb5a05).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2353 +/- ## ======================================= Coverage 53.68% 53.68% ======================================= Files 525 525 Lines 19266 19266 Branches 4066 4066 ======================================= Hits 10341 10341 Misses 8200 8200 Partials 725 725 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lzkb commented 1 month ago

/changelog-entry bug-fix Show the -s, --sso option in the login command help.

github-actions[bot] commented 1 month ago

✅ Thank you for adding the changelog entry!