expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
676 stars 74 forks source link

[eas-json] update image tags in `eas.schema.json` #2363

Closed szdziedzic closed 3 weeks ago

szdziedzic commented 3 weeks ago

Why

Update image tags in eas.schema.json

How

Update image tags in eas.schema.json

Test Plan

Tests

github-actions[bot] commented 3 weeks ago

Size Change: -1.05 kB (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB -1.05 kB (0%)

compressed-size-action

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.63%. Comparing base (917987a) to head (ea58548).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2363 +/- ## ======================================= Coverage 53.63% 53.63% ======================================= Files 530 530 Lines 19483 19483 Branches 4120 4120 ======================================= Hits 10447 10447 Misses 8306 8306 Partials 730 730 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

szdziedzic commented 3 weeks ago

/changelog-entry chore Update image tags in eas.schema.json

szdziedzic commented 3 weeks ago

Does it make sense to mention what is the image for a given SDK? We already show the mapping in docs, maybe there's little upside to having it here too? Not too strong opinion though.

The benefit of having it here is that it shows in VSCode Expo plugin, so it's slightly more convenient for the people

sjchmiela commented 3 weeks ago

I know. Still, if I'm on SDK XX do I care about the actual image doing my build as long as it is successful? (And if it isn't, the image is printed in the worker description.) To rephrase it differently — ideally no one using Expo wants/needs to use anything other than sdk-XX aliases.

szdziedzic commented 3 weeks ago

I mean I don't have a strong opinion, I can just delete it

szdziedzic commented 3 weeks ago

should be better now

github-actions[bot] commented 3 weeks ago

✅ Thank you for adding the changelog entry!