expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
676 stars 74 forks source link

[eas-cli] make sure that spinner is not used for interactive `git clone` command in `inint:onboarding` and fallback to cloning via https #2368

Closed szdziedzic closed 3 weeks ago

szdziedzic commented 3 weeks ago

Why

Before: screenshot_2024-05-09_at_18 56 01_720

spinner was printed on top of the logs which contained a prompt to accept something

fallback to HTTPS if the SSH clone fails

How

make sure that spinner is not used for git clone

fallback to HTTPS if the SSH clone fails

Test Plan

After: screenshot_2024-05-09_at_19 04 12_720

github-actions[bot] commented 3 weeks ago

Size Change: -2.79 kB (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB -2.79 kB (0%)

compressed-size-action

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 4.54545% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 53.55%. Comparing base (b68840b) to head (d38ec18).

Files Patch % Lines
packages/eas-cli/src/onboarding/runCommand.ts 8.34% 10 Missing and 1 partial :warning:
packages/eas-cli/src/onboarding/git.ts 0.00% 9 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2368 +/- ## ========================================== - Coverage 53.60% 53.55% -0.04% ========================================== Files 530 530 Lines 19495 19513 +18 Branches 4121 4134 +13 ========================================== Hits 10448 10448 - Misses 8317 8333 +16 - Partials 730 732 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 weeks ago

⏩ The changelog entry check has been skipped since the "no changelog" label is present.