search

expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
844 stars 85 forks source link

[eas-cli] improve `with-eas-environment-variables-set` flag handling in `eas update` command #2667

Closed szdziedzic closed 2 weeks ago

szdziedzic commented 3 weeks ago

Why

Make the with-eas-environment-variables-set flag reusable and improve type safety and description.

How

Extract with-eas-environment-variables-set to separate file. Improve validation and type safety.

Test Plan

Run command locally.

szdziedzic commented 3 weeks ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @szdziedzic and the rest of your teammates on Graphite Graphite

github-actions[bot] commented 3 weeks ago

Size Change: +4.2 kB (+0.01%)

Total Size: 53 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53 MB +4.2 kB (+0.01%)

compressed-size-action

github-actions[bot] commented 3 weeks ago
Subscribed to pull request File Patterns Mentions
**/* @khamilowicz, @sjchmiela
packages/eas-cli/src/commands/update/** @EvanBacon, @byCedric, @wschurman

Generated by CodeMention

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.93%. Comparing base (7c9970d) to head (97048fe). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2667 +/- ## ========================================== + Coverage 52.92% 52.93% +0.01% ========================================== Files 570 570 Lines 21834 21828 -6 Branches 4297 4293 -4 ========================================== - Hits 11554 11552 -2 + Misses 10246 10242 -4 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. ⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

szdziedzic commented 2 weeks ago

Merge activity