expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
840 stars 85 forks source link

[eas-cli] use full command in error describtion when npx expo config --type introspect command fails #2673

Closed szdziedzic closed 2 weeks ago

szdziedzic commented 2 weeks ago

Why

The error message when reading app config was not accurately reflecting the command being used, which could lead to confusion when troubleshooting configuration issues.

How

Updated the error message in entitlements.ts to include the correct command flag --type introspect when displaying the failure message for reading app config.

szdziedzic commented 2 weeks ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @szdziedzic and the rest of your teammates on Graphite Graphite

github-actions[bot] commented 2 weeks ago

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. ⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

github-actions[bot] commented 2 weeks ago
Subscribed to pull request File Patterns Mentions
**/* @khamilowicz, @sjchmiela

Generated by CodeMention

github-actions[bot] commented 2 weeks ago

Size Change: -1.43 kB (0%)

Total Size: 52.7 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.7 MB -1.43 kB (0%)

compressed-size-action

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.87%. Comparing base (3f2dcc7) to head (d895218).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2673 +/- ## ======================================= Coverage 52.87% 52.87% ======================================= Files 571 571 Lines 21898 21898 Branches 4315 4315 ======================================= Hits 11576 11576 Misses 10288 10288 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.