Closed szdziedzic closed 2 weeks ago
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @szdziedzic and the rest of your teammates on Graphite
❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. ⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.
Subscribed to pull request | File Patterns | Mentions |
---|---|---|
**/* | @khamilowicz, @sjchmiela |
Generated by CodeMention
Size Change: -1.14 kB (0%)
Total Size: 52.7 MB
Filename | Size | Change |
---|---|---|
./packages/eas-cli/dist/eas-linux-x64.tar.gz |
52.7 MB | -1.14 kB (0%) |
Attention: Patch coverage is 21.42857%
with 11 lines
in your changes missing coverage. Please review.
Project coverage is 52.85%. Comparing base (
3f2dcc7
) to head (474a698
).
Files with missing lines | Patch % | Lines |
---|---|---|
packages/eas-cli/src/project/ios/entitlements.ts | 21.43% | 11 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Why
https://exponent-internal.slack.com/archives/C017N0N99RA/p1730892915144259?thread_ts=1730832227.533089&cid=C017N0N99RA
How
import
getPrebuildConfigAsync
andcompileModsAsync
from projectnode_modules
and use them with old arguments vs callnpx expo config --type introspect
which isn't platform-specific and fails because of the bug in the Android template.Test Plan
Test locally on new SDK 52 beta project, see that issue no longer occurs