expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
840 stars 85 forks source link

[eas-cli] improve fingerprint UX #2675

Closed quinlanj closed 1 week ago

quinlanj commented 2 weeks ago

Why

This PR does the following:

How

Compressing project files and uploading to EAS Build. Learn more: https://expo.fyi/eas-build-archive
✔ Uploaded to EAS 
⌛️ Computing project fingerprint taking longer than expected...
⏩ To skip this step, set the environment variable: EAS_SKIP_AUTO_FINGERPRINT=1
✔ Computed project fingerprint

Test Plan

github-actions[bot] commented 2 weeks ago
Subscribed to pull request File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela

Generated by CodeMention

github-actions[bot] commented 2 weeks ago

Size Change: +656 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +656 B (0%)

compressed-size-action

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 7.69231% with 24 lines in your changes missing coverage. Please review.

Project coverage is 52.94%. Comparing base (c30c1cd) to head (6402f90). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/utils/fingerprintCli.ts 7.70% 24 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2675 +/- ## ========================================== - Coverage 52.97% 52.94% -0.03% ========================================== Files 576 576 Lines 22084 22101 +17 Branches 4334 4335 +1 ========================================== + Hits 11697 11699 +2 - Misses 10353 10368 +15 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

✅ Thank you for adding the changelog entry!