expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
840 stars 85 forks source link

[build] Default build-logger-level to debug when EXPO_DEBUG is set #2676

Closed wschurman closed 1 week ago

wschurman commented 2 weeks ago

Why

It's convenient to have this be the default value when trying to debug, so that the whole build can be used to debug. Not set on this, but wanted to see what others thought.

Closes ENG-14060.

How

Default when Log.isDebug is true and flag isn't provided.

Test Plan

  1. EXPO_DEBUG=1 neas build, see debug logs in build.
wschurman commented 2 weeks ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wschurman and the rest of your teammates on Graphite Graphite

linear[bot] commented 2 weeks ago

ENG-14060 Set default build-logger-level based on EXPO_DEBUG

github-actions[bot] commented 2 weeks ago

Size Change: +32 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +32 B (0%)

compressed-size-action

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.94%. Comparing base (027d362) to head (4bc0102). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/build/runBuildAndSubmit.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2676 +/- ## ========================================== - Coverage 52.94% 52.94% -0.00% ========================================== Files 576 576 Lines 22101 22103 +2 Branches 4335 4336 +1 ========================================== + Hits 11699 11700 +1 - Misses 10368 10369 +1 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago
Subscribed to pull request File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela
packages/eas-cli/src/build/** @szdziedzic, @khamilowicz, @sjchmiela

Generated by CodeMention

github-actions[bot] commented 1 week ago

✅ Thank you for adding the changelog entry!