expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
844 stars 85 forks source link

[eas-cli] Honor `EAS_NO_VCS` in `build:internal` #2677

Closed sjchmiela closed 2 weeks ago

sjchmiela commented 2 weeks ago

Why

We need to use build:internal to resolve build configuration in GCS workflow jobs which have no Git repository.

How

I'm going to be adding EAS_NO_VCS=1 to GCS workflow jobs. This should prevent build:internal from requiring Git repository.

Test Plan

I have verified EAS_BUILD_ID=d7fb9f5c-dce0-40e2-b459-cbc05ba1ed77 EAS_NO_VCS=1 easd build:internal -p android prints the JSON output on my computer.

github-actions[bot] commented 2 weeks ago
Subscribed to pull request File Patterns Mentions
**/* @szdziedzic, @khamilowicz
packages/eas-cli/src/commands/build/** @szdziedzic, @khamilowicz

Generated by CodeMention

github-actions[bot] commented 2 weeks ago

Size Change: -2.46 kB (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -2.46 kB (0%)

compressed-size-action

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.97%. Comparing base (b0b1478) to head (ef64a98). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/build/internal.ts 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2677 +/- ## ========================================== - Coverage 52.97% 52.97% -0.00% ========================================== Files 576 576 Lines 22082 22084 +2 Branches 4333 4334 +1 ========================================== + Hits 11696 11697 +1 - Misses 10352 10353 +1 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

⏩ The changelog entry check has been skipped since the "no changelog" label is present.