expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
840 stars 85 forks source link

Adds workflow:create command #2678

Closed jonsamp closed 3 days ago

jonsamp commented 2 weeks ago

Why

Adds eas workflow:create to make it faster to create workflow files in a project. This command creates a file like .eas/workflows/workflow.yml. The user can choose the file name or can provide it as an arugment.

Screenshots

Screenshot 2024-11-08 at 8 50 58 AM Screenshot 2024-11-08 at 8 51 27 AM Screenshot 2024-11-08 at 8 52 04 AM

Test Plan

Make sure that you can run the command as pictured above and that it correctly creates the workflow file. Also make sure that the unit tests pass.

Future

Once we have docs for workflows that are public, I'd like to put a link to the docs in the default file this command creates. For now, I am just putting Hello World as a reasonable placeholder.

linear[bot] commented 2 weeks ago

ENG-14102 Create eas workflow:create command

github-actions[bot] commented 2 weeks ago
Subscribed to pull request File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela

Generated by CodeMention

github-actions[bot] commented 2 weeks ago

Size Change: +1.83 kB (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +1.83 kB (0%)

compressed-size-action

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 32.69231% with 35 lines in your changes missing coverage. Please review.

Project coverage is 52.76%. Comparing base (c7cfcaf) to head (85e6dee). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/workflow/create.ts 33.34% 32 Missing :warning:
packages/eas-cli/src/utils/workflowFile.ts 25.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2678 +/- ## ========================================== - Coverage 52.81% 52.76% -0.04% ========================================== Files 578 579 +1 Lines 22135 22187 +52 Branches 4334 4339 +5 ========================================== + Hits 11688 11705 +17 - Misses 10413 10448 +35 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

github-actions[bot] commented 3 days ago

⏩ The changelog entry check has been skipped since the "no changelog" label is present.