search

expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
840 stars 85 forks source link

[eas-cli] Fix VCS client used for `submit:internal` #2682

Closed sjchmiela closed 1 week ago

sjchmiela commented 1 week ago

Why

Counterpart of https://github.com/expo/eas-cli/pull/2677, applied to submit:internal.

How

Copied the solution from build:internal.

Test Plan

None.

github-actions[bot] commented 1 week ago
Subscribed to pull request File Patterns Mentions
**/* @szdziedzic, @khamilowicz

Generated by CodeMention

github-actions[bot] commented 1 week ago

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

github-actions[bot] commented 1 week ago

Size Change: -13 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -13 B (0%)

compressed-size-action

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.94%. Comparing base (fdb167d) to head (c8896b7). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/submit/internal.ts 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2682 +/- ## ========================================== - Coverage 52.94% 52.94% -0.00% ========================================== Files 576 576 Lines 22103 22105 +2 Branches 4336 4337 +1 ========================================== + Hits 11700 11701 +1 - Misses 10369 10370 +1 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.