expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
840 stars 85 forks source link

[eas-cli] create fingerprint on each update #2687

Closed quinlanj closed 1 day ago

quinlanj commented 1 week ago

Why

This PR computes a fingerprint for each update.

How

Test Plan

quinlanj commented 1 week ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions[bot] commented 1 week ago

Size Change: +711 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +711 B (0%)

compressed-size-action

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 50.00000% with 47 lines in your changes missing coverage. Please review.

Project coverage is 52.79%. Comparing base (fc3c1e7) to head (9eb89a7). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/utils/fingerprintCli.ts 17.15% 29 Missing :warning:
packages/eas-cli/src/project/publish.ts 82.86% 6 Missing :warning:
packages/eas-cli/src/commands/update/index.ts 63.64% 3 Missing and 1 partial :warning:
packages/eas-cli/src/utils/expodash/mapMapAsync.ts 55.56% 4 Missing :warning:
packages/eas-cli/src/build/build.ts 0.00% 2 Missing :warning:
.../eas-cli/src/project/resolveRuntimeVersionAsync.ts 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2687 +/- ## ========================================== + Coverage 52.77% 52.79% +0.03% ========================================== Files 579 580 +1 Lines 22194 22260 +66 Branches 4343 4352 +9 ========================================== + Hits 11710 11750 +40 - Misses 10448 10474 +26 Partials 36 36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

github-actions[bot] commented 1 week ago
Subscribed to pull request File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela
packages/eas-cli/src/build/** @szdziedzic, @khamilowicz, @sjchmiela
packages/eas-cli/src/commands/update/** @EvanBacon, @byCedric, @wschurman

Generated by CodeMention

wschurman commented 3 days ago

(if you want to do republish in a follow-up, request re-review on this one. this looks good otherwise)

wschurman commented 3 days ago

Also, should roll-back-to-embedded updates have this as well? (every command that calls publishUpdateGroupAsync should have it I think?)

quinlanj commented 2 days ago

@wschurman here is the PR for republishing (made separate because of extra dependencies on www changes): https://github.com/expo/eas-cli/pull/2708

I dont think we need to pass on fingerprint info for rollback to embedded. A 'rollback to embedded' directive would always be compatible with whatever build that is targeted. Also, it would technically have the fingerprint of the receiving build (ideally all builds of the same runtime have the same fingerprint, but that's not necessarily the case)

github-actions[bot] commented 1 day ago

✅ Thank you for adding the changelog entry!