Closed quinlanj closed 1 day ago
main
This stack of pull requests is managed by Graphite. Learn more about stacking.
Size Change: +711 B (0%)
Total Size: 52.9 MB
Filename | Size | Change |
---|---|---|
./packages/eas-cli/dist/eas-linux-x64.tar.gz |
52.9 MB | +711 B (0%) |
Attention: Patch coverage is 50.00000%
with 47 lines
in your changes missing coverage. Please review.
Project coverage is 52.79%. Comparing base (
fc3c1e7
) to head (9eb89a7
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Subscribed to pull request | File Patterns | Mentions |
---|---|---|
**/* | @szdziedzic, @khamilowicz, @sjchmiela | |
packages/eas-cli/src/build/** | @szdziedzic, @khamilowicz, @sjchmiela | |
packages/eas-cli/src/commands/update/** | @EvanBacon, @byCedric, @wschurman |
Generated by CodeMention
(if you want to do republish in a follow-up, request re-review on this one. this looks good otherwise)
Also, should roll-back-to-embedded updates have this as well? (every command that calls publishUpdateGroupAsync
should have it I think?)
@wschurman here is the PR for republishing (made separate because of extra dependencies on www changes): https://github.com/expo/eas-cli/pull/2708
I dont think we need to pass on fingerprint info for rollback to embedded. A 'rollback to embedded' directive would always be compatible with whatever build that is targeted. Also, it would technically have the fingerprint of the receiving build (ideally all builds of the same runtime have the same fingerprint, but that's not necessarily the case)
✅ Thank you for adding the changelog entry!
Why
This PR computes a fingerprint for each update.
expo
package for projects SDK 52+.expo-updates
.How
fingerprintHash
instead of the full fingerprint objectTest Plan