expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
840 stars 85 forks source link

[ENG-14204][eas-cli] UX improvements for env:list command #2697

Open szdziedzic opened 1 week ago

szdziedzic commented 1 week ago

Why

Currently using the env:list command is confusing and annoying with this multi-select for environments and too noisy when an env var is secret or sensitive

How

Make it less noisy.

Just use select for environment vs multi-select.

Test Plan

Tested it manually

szdziedzic commented 1 week ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions[bot] commented 1 week ago

Size Change: +790 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +790 B (0%)

compressed-size-action

github-actions[bot] commented 1 week ago
Subscribed to pull request File Patterns Mentions
**/* @khamilowicz, @sjchmiela

Generated by CodeMention

linear[bot] commented 1 week ago

ENG-14204 Use select vs multi-select for `--environment` in EAS CLI commands

github-actions[bot] commented 6 days ago

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. ⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 48.71795% with 20 lines in your changes missing coverage. Please review.

Project coverage is 52.94%. Comparing base (fed28a8) to head (befc501).

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/env/list.ts 60.00% 12 Missing :warning:
packages/eas-cli/src/utils/variableUtils.ts 11.12% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2697 +/- ## ========================================== - Coverage 52.96% 52.94% -0.01% ========================================== Files 576 576 Lines 22095 22097 +2 Branches 4334 4335 +1 ========================================== - Hits 11701 11698 -3 - Misses 10360 10366 +6 + Partials 34 33 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.