expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
840 stars 85 forks source link

[eas-cli] Improve `workflow:run` and `workflow:validate` #2700

Closed sjchmiela closed 3 days ago

sjchmiela commented 6 days ago

Why

We want to check both of these:

How

I added a validateWorkflowRevisionYamlConfig mutation I'm using here to validate the config and GitHub connection. The GitHub requirement is checked dynamically in www so we can later remove it without having users upgrade to a newer eas-cli.

Brent also wished eas workflow:run test.yml resolved test.yml to .eas/workflows/test.yml automatically, so added this too.

Test Plan

I tried validating and running invalid YAMLs, workflows and valid configs. Things seemed to work ok.

linear[bot] commented 6 days ago

ENG-14171 Improve `eas workflow:run`

github-actions[bot] commented 6 days ago

Size Change: +5.45 kB (+0.01%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +5.45 kB (+0.01%)

compressed-size-action

github-actions[bot] commented 6 days ago
Subscribed to pull request File Patterns Mentions
**/* @szdziedzic, @khamilowicz
packages/eas-cli/src/build/** @szdziedzic, @khamilowicz

Generated by CodeMention

github-actions[bot] commented 3 days ago

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 39.24051% with 48 lines in your changes missing coverage. Please review.

Project coverage is 52.81%. Comparing base (fed28a8) to head (ff0a56f). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/utils/workflowFile.ts 26.67% 22 Missing :warning:
packages/eas-cli/src/commands/workflow/validate.ts 31.82% 15 Missing :warning:
packages/eas-cli/src/commands/workflow/run.ts 27.28% 8 Missing :warning:
.../src/graphql/mutations/WorkflowRevisionMutation.ts 75.00% 2 Missing :warning:
packages/eas-cli/src/build/utils/url.ts 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2700 +/- ## ========================================== - Coverage 52.96% 52.81% -0.15% ========================================== Files 576 578 +2 Lines 22095 22139 +44 Branches 4334 4334 ========================================== - Hits 11701 11691 -10 - Misses 10360 10414 +54 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: