expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
840 stars 85 forks source link

[ENG-14249][eas-cli] deprecate eas secret commands #2705

Closed szdziedzic closed 6 hours ago

szdziedzic commented 3 days ago

Why

Deprecate old secret commands

How

Mark as hidden + print warn when used

Test Plan

Tests

linear[bot] commented 3 days ago

ENG-14249 deprecate `eas secret:xyz` commands

szdziedzic commented 3 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions[bot] commented 3 days ago
Subscribed to pull request File Patterns Mentions
**/* @khamilowicz, @sjchmiela

Generated by CodeMention

github-actions[bot] commented 3 days ago

Size Change: -545 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -545 B (0%)

compressed-size-action

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.79%. Comparing base (5bf2c3a) to head (9e3db9a). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/secret/create.ts 33.34% 2 Missing :warning:
packages/eas-cli/src/commands/secret/delete.ts 33.34% 2 Missing :warning:
packages/eas-cli/src/commands/secret/list.ts 33.34% 2 Missing :warning:
packages/eas-cli/src/commands/secret/push.ts 33.34% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2705 +/- ## ========================================== - Coverage 52.80% 52.79% -0.01% ========================================== Files 580 580 Lines 22267 22279 +12 Branches 4354 4354 ========================================== + Hits 11755 11759 +4 - Misses 10476 10484 +8 Partials 36 36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

github-actions[bot] commented 7 hours ago

✅ Thank you for adding the changelog entry!