expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
840 stars 85 forks source link

[eas-cli] update expo packages to SDK 52 versions #2706

Open szdziedzic opened 2 days ago

szdziedzic commented 2 days ago

Why

Update @expo packages to SDK 52 versions

How

Update @expo packages to SDK 52 versions

Fixes #2696

It seems like the privacy field was removed from the expo config in the SDK 52 update: https://expo.dev/changelog/2024/11-12-sdk-52.

I used AppPrivay.Unlisted for the createApp mutation input for which this is still required. It was an option selected for an app when exp.privacy was undefined.

It also seems that findWorkspaceRoot function in @expo/package-manager was changed to resolveWorkspaceRoot.

Test Plan

Tests, test commands manually

szdziedzic commented 2 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions[bot] commented 2 days ago
Subscribed to pull request File Patterns Mentions
**/* @khamilowicz, @sjchmiela
packages/eas-cli/src/update/** @EvanBacon, @byCedric, @wschurman

Generated by CodeMention

github-actions[bot] commented 2 days ago

Size Change: -263 kB (-0.5%)

Total Size: 52.6 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.6 MB -263 kB (-0.5%)

compressed-size-action

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.77%. Comparing base (3111492) to head (0db357b).

Files with missing lines Patch % Lines
...tUtils/findProjectDirAndVerifyProjectSetupAsync.ts 0.00% 1 Missing :warning:
packages/eas-cli/src/vcs/clients/git.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2706 +/- ## ========================================== + Coverage 52.76% 52.77% +0.01% ========================================== Files 579 579 Lines 22187 22176 -11 Branches 4339 4334 -5 ========================================== - Hits 11705 11701 -4 + Misses 10448 10441 -7 Partials 34 34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

github-actions[bot] commented 2 days ago

✅ Thank you for adding the changelog entry!

wschurman commented 2 days ago

Nice catch! This should fix it. https://app.graphite.dev/github/pr/expo/universe/17574/www-No-longer-require-obsolete-privacy-setting-in-app-creation-mutation

szdziedzic commented 2 days ago

Thanks!