Open szdziedzic opened 2 days ago
main
This stack of pull requests is managed by Graphite. Learn more about stacking.
Subscribed to pull request | File Patterns | Mentions |
---|---|---|
**/* | @khamilowicz, @sjchmiela | |
packages/eas-cli/src/update/** | @EvanBacon, @byCedric, @wschurman |
Generated by CodeMention
Size Change: -263 kB (-0.5%)
Total Size: 52.6 MB
Filename | Size | Change |
---|---|---|
./packages/eas-cli/dist/eas-linux-x64.tar.gz |
52.6 MB | -263 kB (-0.5%) |
Attention: Patch coverage is 33.33333%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 52.77%. Comparing base (
3111492
) to head (0db357b
).
Files with missing lines | Patch % | Lines |
---|---|---|
...tUtils/findProjectDirAndVerifyProjectSetupAsync.ts | 0.00% | 1 Missing :warning: |
packages/eas-cli/src/vcs/clients/git.ts | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
✅ Thank you for adding the changelog entry!
Nice catch! This should fix it. https://app.graphite.dev/github/pr/expo/universe/17574/www-No-longer-require-obsolete-privacy-setting-in-app-creation-mutation
Thanks!
Why
Update
@expo
packages to SDK 52 versionsHow
Update
@expo
packages to SDK 52 versionsFixes #2696
It seems like the
privacy
field was removed from the expo config in the SDK 52 update: https://expo.dev/changelog/2024/11-12-sdk-52.I used
AppPrivay.Unlisted
for thecreateApp
mutation input for which this is still required. It was an option selected for an app whenexp.privacy
was undefined.It also seems that
findWorkspaceRoot
function in@expo/package-manager
was changed toresolveWorkspaceRoot
.Test Plan
Tests, test commands manually