expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
840 stars 85 forks source link

[ENG-14185][eas-cli] use account-wide vs shared in env commands #2710

Closed szdziedzic closed 1 day ago

szdziedzic commented 2 days ago

Why

Stick to account-wide everywhere for now

How

Rename shared to account-wide, fix some bugs and type issues

Test Plan

Tests

szdziedzic commented 2 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

linear[bot] commented 2 days ago

ENG-14185 Stick to `account-wide` env vars name everywhere for now

github-actions[bot] commented 2 days ago
Subscribed to pull request File Patterns Mentions
**/* @khamilowicz, @sjchmiela

Generated by CodeMention

github-actions[bot] commented 2 days ago

Size Change: +388 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +388 B (0%)

compressed-size-action

github-actions[bot] commented 1 day ago

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. ⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 84.21053% with 6 lines in your changes missing coverage. Please review.

Project coverage is 52.77%. Comparing base (753df2c) to head (00973fd). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/env/delete.ts 66.67% 1 Missing and 1 partial :warning:
packages/eas-cli/src/commands/env/push.ts 0.00% 2 Missing :warning:
packages/eas-cli/src/commands/env/get.ts 83.34% 0 Missing and 1 partial :warning:
packages/eas-cli/src/commands/env/list.ts 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2710 +/- ## ========================================== + Coverage 52.76% 52.77% +0.01% ========================================== Files 579 579 Lines 22187 22194 +7 Branches 4339 4343 +4 ========================================== + Hits 11705 11710 +5 Misses 10448 10448 - Partials 34 36 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: