expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
840 stars 85 forks source link

[ENG-14223][eas-cli] improve class names and descriptions of env commands #2711

Closed szdziedzic closed 1 day ago

szdziedzic commented 1 day ago

Why

Make class names more consistent with other commands

Improve descriptions

How

Make class names more consistent with other commands

Improve descriptions

Test Plan

Tests

linear[bot] commented 1 day ago

ENG-14223 Improve descriptions and class names of env vars EAS CLI commands

szdziedzic commented 1 day ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions[bot] commented 1 day ago
Subscribed to pull request File Patterns Mentions
**/* @khamilowicz, @sjchmiela

Generated by CodeMention

github-actions[bot] commented 1 day ago

Size Change: +191 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +191 B (0%)

compressed-size-action

github-actions[bot] commented 1 day ago

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. ⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 88.23529% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.77%. Comparing base (bb3915d) to head (e2d65d9). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/env/pull.ts 50.00% 2 Missing :warning:
packages/eas-cli/src/commands/env/push.ts 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2711 +/- ## ======================================= Coverage 52.77% 52.77% ======================================= Files 579 579 Lines 22194 22194 Branches 4343 4343 ======================================= Hits 11710 11710 Misses 10448 10448 Partials 36 36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: