expo / eas-cli

Fastest way to build, submit, and update iOS and Android apps
https://docs.expo.dev/eas/
MIT License
840 stars 85 forks source link

All account-wide envvars should be global (for now) #2713

Closed khamilowicz closed 1 day ago

khamilowicz commented 1 day ago

Why

ENG-14274: Remove linking from eas-cli

Initial release will not include linking account-wide variables to specific projects - they all should be global. Without explicitly setting isGlobal flag, account-wide envvars would be created as non-global, without possibility to link it to anything.

How

Test Plan

Updated tests

linear[bot] commented 1 day ago

ENG-14274 Remove linking from eas-cli

github-actions[bot] commented 1 day ago
Subscribed to pull request File Patterns Mentions
**/* @szdziedzic, @sjchmiela

Generated by CodeMention

github-actions[bot] commented 1 day ago

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

github-actions[bot] commented 1 day ago

Size Change: -884 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB -884 B (0%)

compressed-size-action

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.77%. Comparing base (fc3c1e7) to head (7ff214e). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2713 +/- ## ========================================== + Coverage 52.77% 52.77% +0.01% ========================================== Files 579 579 Lines 22194 22192 -2 Branches 4343 4342 -1 ========================================== - Hits 11710 11709 -1 + Misses 10448 10447 -1 Partials 36 36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: