expo / ex-navigation

Route-centric navigation for React Native
997 stars 201 forks source link

Doesn't handle transparent status bar #300

Open rdixonbhw opened 7 years ago

rdixonbhw commented 7 years ago

The assumption made in ExNavigationBar.js that "Exponent draws under the status bar on Android, but vanilla React Native does not." isn't true for vanilla React Native on Android when there is a <StatusBar transparent/> component mounted.

dantman commented 7 years ago

In fact since ex-navigation is responsible for the entire navigation structure and already has statusBar handling in route.navigationBar, ex-navigation could just ensure the status bar is translucent whenever ex-navigation is mounted whether you're in exponent or vanilla.

As a side note, I also don't like the fact that a hardcoded status bar size is being used instead of StatusBar.currentHeight on Android.