expo / ex-navigator

Route-centric navigation built on top of React Native's Navigator
MIT License
522 stars 68 forks source link

Shorten title length parameter #113

Closed fxhereng closed 8 years ago

fxhereng commented 8 years ago

Following on from the issue #95 , I added a function parameter "shortenTitle".

In case it's not provided, it uses the default shortenTitle function there was in ExRouteRenderer component.

Cheers,

mention-bot commented 8 years ago

By analyzing the blame information on this pull request, we identified @ide, @jesseruder and @brentvatne to be potential reviewers

fxhereng commented 8 years ago

Hi,

Could you merge this request if everything's ok for you guys?

Thanks,

ide commented 8 years ago

You should reimplement renderTitle in this case. We don't really want to expose niche configuration options like this.

fxhereng commented 8 years ago

Then how do you solve this issue? You mean I need to use the renderNavigationBar method in order to have a custom navBar?