search

expo / ex-navigator

Route-centric navigation built on top of React Native's Navigator
MIT License
522 stars 68 forks source link

Add renderBackButtonIcon for backButtonIcon customization #73

Open Kudo opened 8 years ago

Kudo commented 8 years ago

08dc150 is good if we would like to customise all the logic of backButton. However, there are some good part of internal logics, e.g. https://github.com/exponentjs/ex-navigator/blob/master/ExRouteRenderer.js#L94-L113. This change proposes a way to only customise the BackIcon component from ExNavigator. Please feel free to comment and we should discuss here. Now I think there are too many options (propTypes) in ExNavigator interface. While enabling renderBackButtonIcon, barButtonIconStyle is useless and not sure if that would be implicit or not.

mention-bot commented 8 years ago

By analyzing the blame information on this pull request, we identified @ide, @jesseruder and @brentvatne to be potential reviewers

ahanriat commented 8 years ago

@Kudo thanks for this PR, hope it will be merged soon as we currently have a fork for the same reason :smiley:

magrinj commented 8 years ago

:+1: This is really a need!

Emilios1995 commented 8 years ago

This is useful, hope it gets merged.