Example projects that demonstrate how to use Expo APIs and integrate Expo with other popular tools
2.21k
stars
862
forks
source link
Service worker examples incomplete, do not specify the `config` object or `PUBLIC_URL` #414
Open
bradjones1 opened 1 year ago
Describe the bug
The documentation for the service worker example implementation does not explain the
config
object, referenced at https://github.com/expo/examples/blob/bd68019bc808479a3ff99d0a6f69374871713b21/with-workbox/src/serviceWorkerRegistration.js#L23It's kinda-sorta self-explanatory but isn't utilized in the calling code at https://github.com/expo/examples/blob/cfb044b07385773fac2247be968cc5c0b13be8bf/with-workbox/App.js#L23
To Reproduce
n/a
Expected behavior
The
config
object and the required (?)PUBLIC_URL
environment variable are documented.