Migrate to esbuild - Githubissues

expo / expo-2d-context

A pure-js implementation of the W3C's Canvas-2D Context API that can be run on either Expo Graphics or WebGL

112 stars 7 forks source link

Migrate to esbuild #15

Closed iddan closed 3 years ago

iddan commented 3 years ago

Replace Gulp and Babel with esbuild
Replace commonjs imports with ECMAModules imports wherever possible

ide commented 3 years ago

Before we can merge this, we need a test plan to make sure this works in Expo apps. Probably the simplest way to do this is to create a new Expo project, add your local copy of this repo as a dependency, and then render a simple component like the one in this repo's README. Also, since there are changes to the font-related code, the test plan should render fonts as well.

iddan commented 3 years ago

How should we execute the test plan? Should it be a project that can be ran manually or is there a go-to way to run in it in the CI (I couldn't find resources about it)

ide commented 3 years ago

It doesn't need to be automated necessarily. Making a project manually and testing it is fine. Just want to make sure things still work.

iddan commented 3 years ago

As requested a test repository: https://github.com/iddan/expo-2d-context-test. Do notice that we should update the readme example code to use the expo-gl package instead of the deprecated GLView import from expo.

iddan commented 3 years ago

Last week I added tests for fonts, can we move forward with the PR?