search

expo / expo-cli

Tools for creating, running, and deploying universal Expo and React Native apps
https://docs.expo.io/workflow/expo-cli/
2.6k stars 477 forks source link

Possible bug with Push Notifications Key #3948

Closed BrodaNoel closed 2 years ago

BrodaNoel commented 2 years ago

Summary

I think I found a bug in Expo + EAS. Topic: Push Notifications. I'm an old Expo user, who used classic and EAS build. (now currently only EAS).

Some weeks ago I created a new project from scratch. I was configuring the Push Notifications following https://docs.expo.dev/push-notifications/using-fcm/

It say: expo push:android:upload --api-key <your-token-here>

Ok, but... When I go to https://expo.dev/accounts/brodanoel/projects/[SLUG-HERE]/credentials?platform=android, I don't see the credential I just uploaded. I only see the FCM Server Key uploaded in platform=android-classic, which... that may be the reason about why my notifications are not being sent.

In this project, I NEVER used expo-classic build.

PS.:

Screen Shot 2021-10-26 at 12 27 47

I also see this ^^^ in my Apple Certificates... Not sure if what's the bug/reason about notifications not working

Environment

Expo CLI 4.12.10 environment info: System: OS: macOS 11.6 Shell: 5.8 - /bin/zsh Binaries: Node: 14.16.1 - ~/.nvm/versions/node/v14.16.1/bin/node Yarn: 1.22.15 - ~/.yarn/bin/yarn npm: 7.20.3 - ~/.nvm/versions/node/v14.16.1/bin/npm Watchman: 4.9.0 - /usr/local/bin/watchman SDKs: iOS SDK: Platforms: iOS 14.5, DriverKit 20.4, macOS 11.3, tvOS 14.5, watchOS 7.4 Android SDK: API Levels: 23, 25, 26, 27, 29, 30 Build Tools: 23.0.1, 23.0.3, 25.0.3, 26.0.1, 27.0.3, 28.0.3, 29.0.2 System Images: android-22 | Google APIs Intel x86 Atom, android-23 | Intel x86 Atom, android-23 | Google APIs Intel x86 Atom_64, android-29 | Google APIs Intel x86 Atom IDEs: Android Studio: 3.6 AI-192.7142.36.36.6308749 Xcode: 12.5.1/12E507 - /usr/bin/xcodebuild npmPackages: expo: ~42.0.1 => 42.0.3 react: 16.13.1 => 16.13.1 react-dom: 16.13.1 => 16.13.1 react-native: https://github.com/expo/react-native/archive/sdk-42.0.0.tar.gz => 0.63.2 react-native-web: ~0.13.12 => 0.13.18 npmGlobalPackages: expo-cli: 4.12.10 Expo Workflow: managed

Please specify your device/emulator/simulator platform, model and version

MacOS

Error output

No response

Reproducible demo or steps to reproduce from a blank project

N/A

BrodaNoel commented 2 years ago

Yes. I just tried it and it fixed the bug. Now notifications are sent.

So, expo push:android:upload --api-key <your-token-here> should also push to the EAS config. Or, in case that there is an eas push..., it should be described in the documentation

github-actions[bot] commented 2 years ago

This issue is stale because it has been open for 60 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

github-actions[bot] commented 2 years ago

This issue was closed because it has been inactive for 7 days since being marked as stale. Please open a new issue if you believe you are encountering a related problem.