expo / expo-cli

Tools for creating, running, and deploying universal Expo and React Native apps
https://docs.expo.io/workflow/expo-cli/
2.61k stars 477 forks source link

[ENG-8317][cli] deprecate publish:* #4685

Closed quinlanj closed 1 year ago

quinlanj commented 1 year ago

Why

How

Test Plan

Screenshot 2023-04-17 at 11 32 16 PM
linear[bot] commented 1 year ago
ENG-8317 Deprecate "expo publish" in Expo CLI and more cleanup

I noticed a few things with the expo-cli package: 1. Version 6.3.6 is the most recent but latest points to 6.3.2. any issues pointing latest at 6.3.6? 2. Best I can tell, the package isn’t marked as deprecated. Seems like a good idea to do that? 1. and maybe print out a deprecation message every time the command is run? 2. SDK 45 (may 5) was the first release with the beta versioned CLI, SDK 46 (aug 1) was the first release with it out of beta. i believe apple isn’t going to support SDK 45 apps after april 25 because of the xcode requirement so people need to upgrade to 46+ anyway very soon. 3. The expo publish:\* commands don’t say they’re deprecated and replaced by eas. Let’s do that. 4. Similarly, when someone runs one of these commands, print a link to the [sunset blog post](https://blog.expo.dev/sunsetting-expo-publish-and-classic-updates-6cb9cd295378) 5. The expo build:\* commands can be removed. ~even if we don’t want to do a lot of code cleanup work, let’s just remove them from the invokable commands~ 1. Evan had a good point that these commands serve as "redirects" to EAS Build. If someone reads an outdated guide on "expo build" they'll end up at EAS Build because of these stub commands.