expo / expo-cli

Tools for creating, running, and deploying universal Expo and React Native apps
https://docs.expo.io/workflow/expo-cli/
2.6k stars 477 forks source link

[doctor] @expo/metro-config deep dependency check #4742

Closed keith-kurak closed 11 months ago

keith-kurak commented 11 months ago

Why

Based on an issue faced by a user, it was suggested we include @expo/metro-config in deep dependency version checking, to check any case where this package is the wrong version, not just direct installs.

How

  1. Added @expo/metro-config to the staging API with et update-versions -k 'relatedPackages.@expo/metro-config' -v '~0.10.0'.
  2. Updated Doctor to respect EXPO_STAGING=1 for API calls, so then we could test the additional related package in the API.
  3. Added @expo/metro-config to the existing list of deep dependency version checks

Follow-up after merge

Test Plan

Not a perfect check, because installing @expo/metro-config already results in the warning from npx expo install --check, but you can see here now it also triggers the deep dependency check:

image