feature(preview): add `qr-target` and use proper QR codes for `expo-go` and `dev-build` - Githubissues

expo / expo-github-action

Expo GitHub Action makes it easy to automate EAS builds or updates

MIT License

795 stars 77 forks source link

feature(preview): add `qr-target` and use proper QR codes for `expo-go` and `dev-build` #247

Closed byCedric closed 11 months ago

byCedric commented 11 months ago

⚠️ Warning This changes the default behavior around QR codes, and in rare cases might be a breaking change. But, since the QR codes are broken as is, we are releasing this as a minor version.

This PR fixes the QR codes for both Expo Go and Dev Client projects.

It infers if expo-dev-client is currently used in the project, and if so, it uses the exp+<slug>:// QR code prefix.
When using Expo Go, it defaults to the actual EAS Update link itself. This can be opened in Expo Go when not using any custom modules.

You can override this logic by setting the qr-target: expo-go | dev-build.

Troubleshouting

If you run into issues with expo-dev-client QR codes, follow these steps.

Make sure the expo-dev-client plugin is added to the app.json plugins list.
Make sure your expo-dev-client build can be opened through an exp+<slug>:// deep link. (see #240)
Make sure you have the development build, not a production build. Only development builds can open arbitrary EAS Update links.

Linked issue

See #240

expo-bot commented 11 months ago

:tada: This PR is included in version 8.2.0 :tada:

The release is available on:

8.2.0
GitHub release

Your semantic-release bot :package::rocket: