eas update fails with an env file

HamzaKV commented 10 months ago

Description of the bug

How would you shortly summarise the issue? Using expo/expo-github-action/preview@v8 with a .env file in the project causes the action to fail with the error: "Error: Unexpected token 'e', "env: load "... is not valid JSON"

To Reproduce

What steps did you perform which led to this issue?

Setup project to read .env files
Have a .env file in the project
Use expo/expo-github-action/preview@v8 to update branch based on pr
Use command eas update --auto

Expected behavior

What did you expect to have happened? GitHub action should update without errors

Actual behavior

What did it actually result in? Error: Unexpected token 'e', "env: load "... is not valid JSON

Additional context

Can you further explain the issue? E.g., information about version/environment or screenshots. Action uses latest ubuntu, and latest eas versions

edenjiga commented 10 months ago

Hi im having the same issue, any update on this?

byCedric commented 10 months ago

Hi all! Can you provide a repro with this error showing up? It could be a bug within eas-cli itself. This GitHub action only executes that CLI, and uses the returned JSON data.

This could also have been related to an earlier bug: https://github.com/expo/expo/pull/24192.

Make sure you have the latest versions, e.g. through npx expo install --fix.

sguha00 commented 10 months ago

I'm getting the same issue too

Run expo/expo-github-action/preview@v8
  with:
    command: eas update --branch update-expo-action --message "Fix double quote" --platform=ios
    comment: true
    working-directory: /home/runner/work/KDS/KDS
    github-token: ***
  env:
    BRANCH_NAME: update-expo-action
    EXPO_TOKEN: ***
/opt/hostedtoolcache/eas-cli/6.0.0/x64/node_modules/.bin/eas --version
eas-cli/6.0.0 linux-x64 node-v18.17.1
Run eas update --branch update-expo-action --message "Fix double quote" --platform=ios --json --non-interactive"
  /opt/hostedtoolcache/eas-cli/6.0.0/x64/node_modules/.bin/eas update --branch update-expo-action --message Fix double quote --platform=ios --json --non-interactive
  - Exporting...
  [expo-cli] Starting Metro Bundler
  - Exporting...
  [expo-cli] 
  - Exporting...
  [expo-cli] iOS Bundling complete 115714ms
  - Exporting...
  [expo-cli] 
  - Exporting...
  [expo-cli] iOS Building Hermes bytecode for the bundle
  - Exporting...
  [expo-cli] 
  - Exporting...
  [expo-cli] Bundle                  Size
  - Exporting...
  [expo-cli] ┌ index.ios.hbc      6.13 MB
  - Exporting...
  [expo-cli] └ index.ios.hbc.map  19.5 MB
  - Exporting...
  [expo-cli] 💡 JavaScript bundle sizes affect startup time. Learn more: https://expo.fyi/javascript-bundle-sizes
  - Exporting...
  [expo-cli] 
  - Exporting...
  [expo-cli] Finished saving JS Bundles
  - Exporting...
  [expo-cli] Saving assets
  - Exporting...
  [expo-cli] saving /node_modules/@react-navigation/elements/src/assets/back-icon@1x.ios.png
  - Exporting...
  [expo-cli] saving /node_modules/@react-navigation/elements/src/assets/back-icon@1.5x.ios.png
  - Exporting...
  [expo-cli] saving /node_modules/@react-navigation/elements/src/assets/back-icon@[2](https://github.com/instamenu/KDS/actions/runs/7568135750/job/20608707210?pr=652#step:9:2)x.ios.png
  - Exporting...
  [expo-cli] saving /node_modules/@react-navigation/elements/src/assets/back-icon@[3](https://github.com/instamenu/KDS/actions/runs/7568135750/job/20608707210?pr=652#step:9:3)x.ios.png
  - Exporting...
  [expo-cli] saving /node_modules/@react-navigation/elements/src/assets/back-icon@[4](https://github.com/instamenu/KDS/actions/runs/7568135750/job/20608707210?pr=652#step:9:4)x.ios.png
  - Exporting...
  [expo-cli] saving /node_modules/@react-navigation/elements/src/assets/back-icon-mask.png
  - Exporting...
  [expo-cli] saving /node_modules/@react-navigation/drawer/src/views/assets/toggle-drawer-icon@1x.ios.png
  - Exporting...
  [expo-cli] saving /node_modules/@react-navigation/drawer/src/views/assets/toggle-drawer-icon@1.[5](https://github.com/instamenu/KDS/actions/runs/7568135750/job/20608707210?pr=652#step:9:5)x.ios.png
  - Exporting...
  [expo-cli] saving /node_modules/@react-navigation/drawer/src/views/assets/toggle-drawer-icon@2x.ios.png
  - Exporting...
  [expo-cli] saving /node_modules/@react-navigation/drawer/src/views/assets/toggle-drawer-icon@3x.ios.png
  - Exporting...
  [expo-cli] saving /node_modules/@react-navigation/drawer/src/views/assets/toggle-drawer-icon@4x.ios.png
  - Exporting...
  [expo-cli] saving /assets/fonts/GothamSSm-Bold.otf
  - Exporting...
  [expo-cli] saving /assets/fonts/GothamSSm-Book.otf
  - Exporting...
  [expo-cli] saving /assets/fonts/GothamSSm-Medium.otf
  - Exporting...
  [expo-cli] saving /node_modules/@expo/vector-icons/build/vendor/react-native-vector-icons/Fonts/MaterialCommunityIcons.ttf
  - Exporting...
  [expo-cli] saving /node_modules/react-native-paper/src/assets/back-chevron.png
  - Exporting...
  [expo-cli] saving /assets/sounds/NewAlert.mp3
  - Exporting...
  [expo-cli] saving /assets/sounds/5MinAlert.mp3
  - Exporting...
  [expo-cli] saving /assets/sounds/10MinAlert.mp3
  - Exporting...
  [expo-cli] Files successfully saved.
  - Exporting...
  [expo-cli] Processing asset bundle patterns:
  - Exporting...
  [expo-cli] - /home/runner/work/KDS/KDS/**/*
  - Exporting...
  [expo-cli] Dumping asset map
  - Exporting...
  [expo-cli] Dumping source maps
  - Exporting...
  [expo-cli] Preparing additional debugging files
  - Exporting...
  [expo-cli] Export was successful. Your exported files can be found in dist
  - Exporting...
  ✔ Exported bundle(s)
  - Uploading...
  ✔ Uploaded 1 app bundle
  ✔ Uploading assets skipped - no new assets found
  ℹ 21 iOS assets (maximum: 2000 total per update). Learn more about asset limits.: https://expo.fyi/eas-update-asset-limits
  - Publishing...
  ✔ Published!
  [
    {
      "id": "9a72314f-31de-4f21-808f-73[6](https://github.com/instamenu/KDS/actions/runs/7568135750/job/20608707210?pr=652#step:9:6)81[7](https://github.com/instamenu/KDS/actions/runs/7568135750/job/20608707210?pr=652#step:9:7)7ea374",
      "createdAt": "2024-01-1[8](https://github.com/instamenu/KDS/actions/runs/7568135750/job/20608707210?pr=652#step:9:8)T0[9](https://github.com/instamenu/KDS/actions/runs/7568135750/job/20608707210?pr=652#step:9:9):50:42.309Z",
      "group": "44dd44f5-75f9-4d1d-8f6b-8c5222b6bc00",
      "branch": "update-expo-action",
      "message": "Fix double quote",
      "runtimeVersion": "exposdk:49.0.0",
      "platform": "ios",
      "manifestPermalink": "https://u.expo.dev/update/9a72314f-31de-4f21-808f-7368177ea374",
      "isRollBackToEmbedded": false,
      "gitCommitHash": "d6[13](https://github.com/instamenu/KDS/actions/runs/7568135750/job/20608707210?pr=652#step:9:14)a4f8e13[14](https://github.com/instamenu/KDS/actions/runs/7568135750/job/20608707210?pr=652#step:9:15)d45db3bd6df935d0d0d31a02[16](https://github.com/instamenu/KDS/actions/runs/7568135750/job/20608707210?pr=652#step:9:17)8"
    }
  ]
Error: Unexpected token 'e', "env: load "... is not valid JSON

sguha00 commented 10 months ago

Hi all! Can you provide a repro with this error showing up? It could be a bug within eas-cli itself. This GitHub action only executes that CLI, and uses the returned JSON data.

This could also have been related to an earlier bug: expo/expo#24192.

Make sure you have the latest versions, e.g. through npx expo install --fix.

Updating to expo 49.0.21 got it working for me. For some reason npx expo install --fix didn't update me from 49.0.16, I had to do it manually

HamzaKV commented 8 months ago

Updating to latest sdk worked thank you

expo / expo-github-action