search

expo / expo-github-action

Expo GitHub Action makes it easy to automate EAS builds or updates
MIT License
795 stars 77 forks source link

Image Size v1.1.0 not compatible with expo-github-action #249

Closed christina-kirk closed 10 months ago

christina-kirk commented 10 months ago

Description of the bug

How would you shortly summarise the issue? The latest version of image-size@1.1.0 requires a minimum node version of 18 but upgrading to node 18 breaks the expo-cli@5.6.0 which requires a node version >=12 <=16

The image-size@1.1.0 was released December 28, 2023

To Reproduce

  1. Run expo/expo-github-action@v8 in a github action
  2. See failure in the "Setup Expo and EAS" step Installing expo-cli (5.6.0) from cache or with yarn
  3. Error described below: 
    error image-size@1.1.0: The engine "node" is incompatible with this module. Expected version ">=18.0.0". Got "16.20.2"
error Found incompatible module.

Expected behavior

expo/expo-github-action@v8 should not fail as a github action

Actual behavior

expo/expo-github-action@v8 is failing and blocking later build steps

Additional context

Can you further explain the issue? E.g., information about version/environment or screenshots.

christina-kirk commented 10 months ago

Looks like image-size library resolved this on their own: https://github.com/image-size/image-size/commit/fab15a51f60b47b4cef3a8842d3bbe97213cb2ab

Closing this as the action is no longer blocked