search

expo / expo-pixi

Tools for using pixi.js in Expo
MIT License
304 stars 119 forks source link

Fixes to make ExpoPixi.Signature work on web #148

Open guyzmo opened 3 years ago

guyzmo commented 3 years ago
  1. disables the getContextAttributes from context on web platform cf #147
  2. changes the ref assignment for GLView. There's an issue opened on expo-gl, because I believe it should be fixed there, not here. cf expo/expo#10774.
  3. Fixes the takeSnapshotAsync() call for the web platform by using the static call. I'm not sure why the local utils one is actually failing to call the bound one.

About 3. I did not make an issue, because even though the takeSnapshotAsync call works, it only saves blank images. I need to figure out why (maybe I'm giving it a wrong context? 🤔 )

This could be three distinct one commit PR, though I believe they all belong together as it's achieving one goal: make Signature work on the web :)

guyzmo commented 3 years ago

Hello 👋 It's been almost a year since I pushed that PR and that I'm running a fork of expo-pixi. Is there someone left to maintain this code base ? 🤔